Skip to content

fix(migrations): enable encapsulation for migrations #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lipata merged 2 commits into from
Dec 12, 2024
Merged

fix(migrations): enable encapsulation for migrations #1361

Lipata merged 2 commits into from
Dec 12, 2024

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Dec 10, 2024

@coveralls
Copy link

coveralls commented Dec 10, 2024

Coverage Status

coverage: 70.041%. remained the same
when pulling 7c1e8ee on nalipiev/fix-migrations
into 22757ca on master.

@Lipata
Copy link
Member Author

Lipata commented Dec 11, 2024 •
edited
Loading

Test by trying to update igniteui-cli to the latest 14.3.x:

ng update igniteui-cli. The following error should be fixed by this PR:

image

@valadzhov
Copy link
Contributor

valadzhov commented Dec 12, 2024

Tested by packing the branch, installing it and then executing ng update igniteui-cli

@Lipata Lipata merged commit 9561a16 into master Dec 12, 2024
3 checks passed
@Lipata Lipata deleted the nalipiev/fix-migrations branch December 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

Assignees

@valadzhov valadzhov

Labels

migration version: 14.3.x ✅ status: verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Lipata @coveralls @valadzhov @jackofdiamond5